support for image attachments when classifying questions #6675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f5067e to
a3ecf60
Compare
229c1be to
56357ef
Compare
|
I am not certain that we need to support images at the moment. Adding images will require a headless browser to do the capturing and it's going to raise the cost per query without knowing at this point if we need this. Preliminary testing shows that using just text works fine. Because of the above, I am hesitant to add code that we don't know if we are going to need |
No, adding images like this does not require a headless browser. This code works as it is. I've already tested it. Our VertexAI backend grabs the images from the URL's we provide, and feeds them into the LLM along with the text. |
3e600f3 to
e9ff20e
Compare
e9ff20e to
72f4391
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mozilla/sumo#2344